| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Cc: | Ajin Cherian <itsajin(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Önder Kalacı <onderkalaci(at)gmail(dot)com>, japin <japinli(at)hotmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: row filtering for logical replication |
| Date: | 2021-10-26 04:55:28 |
| Message-ID: | CAHut+PuLcT6iqS+2XKt_w_gGrs_ZmT37HrucLT4jEvRKO+Cpyg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 23, 2021 at 10:33 PM Tomas Vondra
<tomas(dot)vondra(at)enterprisedb(dot)com> wrote:
>
> 7) exprstate_list
>
> I'd just call the field / variable "exprstates", without indicating the
> data type. I don't think we do that anywhere.
Fixed in v34. [1]
>
>
> 8) RfCol
>
> Do we actually need this struct? Why not to track just name or attnum,
> and lookup the other value in syscache when needed?
>
Fixed in v34. [1]
>
> 9) rowfilter_expr_checker
>
> * Walk the parse-tree to decide if the row-filter is valid or not.
>
> I don't see any clear explanation what does "valid" mean.
>
Updated comment in v34. [1]
Kind Regards,
Peter Smith.
Fujitsu Australia.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2021-10-26 05:01:08 | Re: row filtering for logical replication |
| Previous Message | Peter Smith | 2021-10-26 04:24:43 | Re: row filtering for logical replication |