| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Hou, Zhijie/侯 志杰 <houzj(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Subject: | Re: Logical Replication of sequences |
| Date: | 2024-08-16 04:55:56 |
| Message-ID: | CAHut+Pu5dOpDPRpOt+uBb3MK+-O_2ig4W5RamZRfjp4WYna95A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Vignesh. I looked at the latest v20240815* patch set.
I have only the following few comments for patch v20240815-0004, below.
======
Commit message.
Please see the attachment for some suggested updates.
======
src/backend/commands/subscriptioncmds.c
CreateSubscription:
nit - fix wording in one of the XXX comments
======
.../replication/logical/sequencesync.c
report_mismatched_sequences:
nit - param name /warning_sequences/mismatched_seqs/
append_mismatched_sequences:
nit - param name /warning_sequences/mismatched_seqs/
LogicalRepSyncSequences:
nit - var name /warning_sequences/mismatched_seqs/
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| PS_NITPICKS_20240816_seq_0004.txt | text/plain | 3.9 KB |
| 20240816_PS_COMMIT_MESSAGE_SEQ_0004 | application/octet-stream | 3.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Steven Niu | 2024-08-16 05:16:33 | Re: [Patch] remove duplicated smgrclose |
| Previous Message | Peter Eisentraut | 2024-08-16 04:48:15 | Re: libpq minor TOCTOU violation |