| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Rajendra Kumar Dangwal <dangwalrajendra888(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, euler(at)eulerto(dot)com |
| Subject: | Re: Pgoutput not capturing the generated columns |
| Date: | 2024-11-05 07:02:24 |
| Message-ID: | CAHut+Pu0wKYT2CwpdMOrP5shf7C4Ti-h6cuUE5hpC56pig210A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Vignesh,
Here are my review comments for patch v48-0001.
======
src/backend/catalog/pg_publication.c
has_column_list_defined:
1.
+ if (HeapTupleIsValid(cftuple))
+ {
+ bool isnull = true;
+
+ /* Lookup the column list attribute. */
+ (void) SysCacheGetAttr(PUBLICATIONRELMAP, cftuple,
+ Anum_pg_publication_rel_prattrs,
+ &isnull);
AFAIK it is not necessary to assign a default value to 'isnull' here.
e.g. most of the other 100s of calls to SysCacheGetAttr elsewhere in
PostgreSQL source don't bother to do this.
//////////
I also checked the docs patch v48-0002. That now looks good to me.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2024-11-05 07:12:50 | Re: general purpose array_sort |
| Previous Message | Masahiko Sawada | 2024-11-05 07:01:23 | Re: New "raw" COPY format |