| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | Re: Synchronizing slots from primary to standby |
| Date: | 2024-06-06 04:21:15 |
| Message-ID: | CAHut+Pu0WcTdUS1oz-1u2nOVohG6dBVokb1oh8zXUNZf4OnnEQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, here are some review comments for the docs patch v5-0001.
Apart from these it LGTM.
======
doc/src/sgml/logical-replication.sgml
1.
+ <para>
+ On the subscriber node, use the following SQL to identify which slots
+ should be synced to the standby that we plan to promote. This query will
+ return the relevant replication slots, including the main slots and table
+ synchronization slots associated with the failover enabled subscriptions.
/failover enabled/failover-enabled/
~~~
2.
+ <para>
+ If all the slots are present on the standby server and result
+ (<literal>failover_ready</literal>) of is true, then existing subscriptions
+ can continue subscribing to publications now on the new primary server
+ without any loss of data.
+ </para>
Hmm. It looks like there is some typo or missing words here: "of is true".
Did you mean something like: "of the above SQL query is true"?
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-06-06 04:29:26 | Re: Fix use of possible uninitialized variable retval (src/pl/plpgsql/src/pl_handler.c) |
| Previous Message | Amit Kapila | 2024-06-06 04:04:13 | Re: Logical Replication of sequences |