| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, exclusion(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18558: ALTER PUBLICATION fails with unhelpful error on attempt to use system column |
| Date: | 2024-08-02 02:51:46 |
| Message-ID: | CAHut+Ptp6Ztk-Dst_WDmQpAw+Zy9EbP_8QSNk5NkDEjP=8xK-A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Sorry for my delay getting back to this thread.
Here is an updated patch v3 which has the following changes.
1. API.
The publication_translate_columns function now optionally returns the
Bitmapset* (that it was building anyway). The function comment was
also changed.
The patch is not quite the radical change suggested above [1]. I found
the currently returned 'attarray' is used in multiple places (in
publication_add_relation) so it seemed less invasive to leave those
other publication_translate_columns parameters as-is.
2. Tests.
Patch is now also testing for duplicates in a publication column list
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-fix-new-collist-validation-msg.patch | application/octet-stream | 6.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2024-08-02 04:13:25 | Re: Inconsistency of timezones in postgresql |
| Previous Message | David G. Johnston | 2024-08-01 19:46:34 | Re: BUG #18565: Job finishes successfully but reruns unwanted!!! |