DOCS: pg_createsubscriber wrong link?

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: DOCS: pg_createsubscriber wrong link?
Date: 2024-12-13 05:27:38
Message-ID: CAHut+PtnA4DB_pcv4TDr4NjUSM1=P2N_cuZx5DX09k7LVmaqUA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

While reviewing the pg_createsubscriber [1] docs I found a potentially
wrong linkend.

This sentence:
"For smaller databases, initial data synchronization is recommended."

links to [2] ("29.4.5. Initial Data Synchronization").

This seems to have been deliberately changed (commit [3])

FROM: <link linkend="logical-replication">initial data synchronization</link>

TO: <link linkend="logical-replication-row-filter-initial-data-sync">initial
data synchronization</link>

Although the title "Initial Data Synchronization" seems at face value
to be relevant, this particular link target is a sub-section of "Row
Filters", so I don't see why this would be the intended link from the
pg_createsubscriber. AFAICT, the original discussion and commit
message does not explain.

~~

Here is a new patch giving an alternate link which IMO might be more
appropriate.

Thoughts?

======
[1] https://www.postgresql.org/docs/current/app-pgcreatesubscriber.html
[2] https://www.postgresql.org/docs/current/logical-replication-row-filter.html#LOGICAL-REPLICATION-ROW-FILTER-INITIAL-DATA-SYNC
[3] https://github.com/postgres/postgres/commit/84db9a0eb10dd1dbee6db509c0e427fa237177dc

Kind Regards,
Peter Smith.
Fujitsu Australia

Attachment Content-Type Size
v1-0001-DOCS-Fix-wrong-linkend-on-pg_createsubscriber-pag.patch application/octet-stream 1.2 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hunaid Sohail 2024-12-13 05:29:28 Re: [PATCH] Add roman support for to_number function
Previous Message Corey Huinker 2024-12-13 05:22:38 Re: Statistics Import and Export