From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
---|---|
To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: doc: improve the restriction description of using indexes on REPLICA IDENTITY FULL table. |
Date: | 2023-07-12 23:03:27 |
Message-ID: | CAHut+PtkW75+k8ENQj5+jyxyz4SkPXApbvyA3sidsBqhQ1gT+Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jul 12, 2023 at 5:01 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Tue, Jul 11, 2023 at 5:31 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > Here are my comments for v4.
> >
> > ======
> >
> > Docs/Comments:
> >
> > ====
>
> Agreed. I've attached the updated patch. I'll push it barring any objections.
>
> >
I checked v5-0001 and noticed the following:
======
doc/src/sgml/logical-replication.sgml
BEFORE
... and the leftmost index field must be a column (not an expression)
that reference a published table column.
SUGGESTION ("references the", instead of "reference a")
... and the leftmost index field must be a column (not an expression)
that references the published table column.
(maybe that last word "column" is also unnecessary?)
======
src/backend/replication/logical/relation.c
BEFORE
The index must be btree, non-partial, and the leftmost field must be a
column (not an expression) that reference the remote relation.
SUGGESTION ("references", instead of "reference")
The index must be btree, non-partial, and the leftmost field must be a
column (not an expression) that references the remote relation.
------
Kind Regards,
Peter Smith.
Fujitsu Australia
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2023-07-12 23:11:49 | Re: Correct the documentation for work_mem |
Previous Message | Michael Paquier | 2023-07-12 22:50:16 | Re: 'ERROR: attempted to update invisible tuple' from 'ALTER INDEX ... ATTACH PARTITION' on parent index |