Re: Re-order "disable_on_error" in tab-complete COMPLETE_WITH

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Euler Taveira <euler(at)eulerto(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Re-order "disable_on_error" in tab-complete COMPLETE_WITH
Date: 2022-07-04 22:33:05
Message-ID: CAHut+Ptbcgp05xR=aOjac9AUN3FSo2_BnkHAnJqWdMVrE0640A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 4, 2022 at 10:29 PM Euler Taveira <euler(at)eulerto(dot)com> wrote:
>
> On Mon, Jul 4, 2022, at 5:37 AM, Amit Kapila wrote:
>
> Yeah, it seems we have overlooked this point. I think we can do this
> just for HEAD but as the feature is introduced in PG-15 so there is no
> harm in pushing it to PG-15 as well especially because it is a
> straightforward change. What do you or others think?
>
> No objection. It is a good thing for future backpatches.
>

Since there is no function change or bugfix here I thought it was only
applicable for HEAD. This change is almost in the same category as a
code comment typo patch - do those normally get backpatched? - maybe
follow the same convention here. OTOH, if you think it may be helpful
for future backpatches then I am also fine if you wanted to push it to
PG15.

------
Kind Regards,
Peter Smith.
Fujitsu Australia

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-07-04 22:58:31 Re: TAP output format in pg_regress
Previous Message Daniel Gustafsson 2022-07-04 22:11:13 Re: TAP output format in pg_regress