| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Refactor to make use of a common function for GetSubscriptionRelations and GetSubscriptionNotReadyRelations. |
| Date: | 2022-07-13 07:47:59 |
| Message-ID: | CAHut+Pt9h73vdB6Xcj-FybPew7bUYBhxK1p8Z9HOATyXKNjwmw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 13, 2022 at 5:43 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Jul 13, 2022 at 12:22:06PM +0530, vignesh C wrote:
> > Most of the code is common between GetSubscriptionRelations and
> > GetSubscriptionNotReadyRelations. Added a parameter to
> > GetSubscriptionRelations which could provide the same functionality as
> > the existing GetSubscriptionRelations and
> > GetSubscriptionNotReadyRelations. Attached patch has the changes for
> > the same. Thoughts?
>
> Right. Using all_rels to mean that we'd filter relations that are not
> ready is a bit confusing, though. Perhaps this could use a bitmask as
> argument.
+1
(or some enum)
------
Kind Regards,
Peter Smith.
Fujitsu Australia.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2022-07-13 07:48:41 | Re: Making Vars outer-join aware |
| Previous Message | Michael Paquier | 2022-07-13 07:43:29 | Re: Refactor to make use of a common function for GetSubscriptionRelations and GetSubscriptionNotReadyRelations. |