Re: Single transaction in the tablesync worker?

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Single transaction in the tablesync worker?
Date: 2021-01-25 11:41:46
Message-ID: CAHut+Pt2nj5hT66okV=fkzuBLXJY+Kw5p=fBW-aYfzWM1q2p4g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jan 25, 2021 at 2:54 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Mon, Jan 25, 2021 at 8:23 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > On Sat, Jan 23, 2021 at 11:26 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > >
> > > 2.
> > > @@ -98,11 +102,16 @@
> > > #include "miscadmin.h"
> > > #include "parser/parse_relation.h"
> > > #include "pgstat.h"
> > > +#include "postmaster/interrupt.h"
> > > #include "replication/logicallauncher.h"
> > > #include "replication/logicalrelation.h"
> > > +#include "replication/logicalworker.h"
> > > #include "replication/walreceiver.h"
> > > #include "replication/worker_internal.h"
> > > +#include "replication/slot.h"
> > >
> > > I don't think the above includes are required. They seem to the
> > > remnant of the previous approach.
> > >
> >
> > OK. Fixed in the latest patch [v19].
> >
>
> You seem to forgot removing #include "replication/slot.h". Check, if
> it is not required then remove that as well.
>

Fixed in the latest patch [v20].

----
[v20] https://www.postgresql.org/message-id/CAHut%2BPuNwSujoL_dwa%3DTtozJ_vF%3DCnJxjgQTCmNBkazd8J1m-A%40mail.gmail.com

Kind Regards,
Peter Smith.
Fujitsu Australia

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2021-01-25 11:47:47 Re: Single transaction in the tablesync worker?
Previous Message Peter Smith 2021-01-25 11:39:54 Re: Single transaction in the tablesync worker?