| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: Add common function ReplicationOriginName. |
| Date: | 2022-09-20 09:03:06 |
| Message-ID: | CAHut+Pswa-x9T=0xHScm0TTB_h1sHNMyeYn80_5T5V5SPqXVvA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 20, 2022 at 6:36 PM Aleksander Alekseev
<aleksander(at)timescale(dot)com> wrote:
>
> Hi Amit,
>
> > I think it is better to use Size. Even though, it may not fail now as
> > the size of names for origin will always be much lesser but it is
> > better if we are consistent. If we agree with this, then as a first
> > patch, we can make it to use Size in existing places and then
> > introduce this new function.
>
> OK, here is the updated patchset.
>
> * 0001 replaces int's with Size's in the existing code
> * 0002 applies Peter's patch on top of 0001
>
LGTM. Thanks!
-----
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2022-09-20 09:26:43 | Re: Add 64-bit XIDs into PostgreSQL 15 |
| Previous Message | Himanshu Upadhyaya | 2022-09-20 08:59:52 | Re: HOT chain validation in verify_heapam() |