| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Ajin Cherian <itsajin(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Skip collecting decoded changes of already-aborted transactions |
| Date: | 2024-11-25 04:50:14 |
| Message-ID: | CAHut+PsraMChmh=Tthu9_YHHN_c-mOqM-0pBXHeonhT7vE8qPA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, Here are my review comments for patch v9-0001.
These are only trivial nits for some code comments. Everything else
looked good to me.
======
.../replication/logical/reorderbuffer.c
ReorderBufferTruncateTXN:
1.
+ * The given transaction is marked as streamed if appropriate and the caller
+ * asked it by passing 'mark_txn_streaming' being true.
/asked it/requested it/
/being true/as true/
~~~
ReorderBufferPrepare:
2.
+ /*
+ * Remember if the transaction is already aborted to check if we detect
+ * that the transaction is concurrently aborted during the replay.
+ */
SUGGESTION:
Remember if the transaction is already aborted so we can detect when
the transaction is concurrently aborted during the replay.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2024-11-25 04:54:47 | Re: Enhancing Memory Context Statistics Reporting |
| Previous Message | Tristan Partin | 2024-11-25 04:07:55 | Re: Add support for Tcl 9 |