| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Shinoda, Noriyoshi (SXD Japan FSIP)" <noriyoshi(dot)shinoda(at)hpe(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Rajendra Kumar Dangwal <dangwalrajendra888(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "euler(at)eulerto(dot)com" <euler(at)eulerto(dot)com> |
| Subject: | Re: Pgoutput not capturing the generated columns |
| Date: | 2025-01-12 23:55:24 |
| Message-ID: | CAHut+PsPZVE8r1VeznuF3hSiTxcbprzaiBedSmMv39FYoHn4YA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Some patches of this thread have fallen though the cracks for more
than 2 months now, so I am re-posting them so that do not get
overlooked any longer.
For v49 [1] there were 2 patches:
v49-0001-Enable-support-for-publish_generated_columns-par
v49-0002-DOCS-Generated-Column-Replication
Then, at v50 [2] there were 2 patches:
v50-0001-Replicate-generated-columns-when-publish_generat
v50-0002-Tap-tests-for-generated-columns
Notice the DOCS patch is missing in v50.
Those v50* patches were then pushed to master. But, that was 2 months ago.
~~
So, the v49-0002-DOCS patch (which added a new section to Chapter 29)
remains still unpushed.
Meanwhile, it was reported [3] that pubgencols attribute of the
pg_publication catalog is missing from the docs.
~~
In this post, I have attached v51* patches where:
v51-0001 - This is a rebase of the missing DOCS patch from v49.
v51-0002 - This is the pg_publication catalog missing pubgencols
attribute patch.
~~~
Future -- there probably need to be further clarifications/emphasis to
describe how the generated column replication feature only works for
STORED generated columns (not VIRTUAL ones), but IMO it is better to
address that separately *after* dealing with these missing
documentation patches.
======
[1] v49 - https://www.postgresql.org/message-id/CALDaNm3XV5mAeZzZMkOPSPieANMaxOH8xAydLqf8X5PQn%2Ba5EA%40mail.gmail.com
[2] v50 - https://www.postgresql.org/message-id/CALDaNm1hR9-xFZXiK0it_ohn%2BPvfKTLvoOFhBi7p9oTSRCPJRg%40mail.gmail.com
[3] pg_publication -
https://www.postgresql.org/message-id/DM4PR84MB1734D79B25D5B427F5B6101AEE5C2%40DM4PR84MB1734.NAMPRD84.PROD.OUTLOOK.COM
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v51-0002-Add-missing-pubgencols-attribute-docs-for-pg_pub.patch | application/octet-stream | 1.1 KB |
| v51-0001-DOCS-Generated-Column-Replication.patch | application/octet-stream | 12.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2025-01-13 00:15:16 | Re: Pgoutput not capturing the generated columns |
| Previous Message | Jelte Fennema-Nio | 2025-01-12 23:11:49 | Re: Include patch id in commitfest page |