From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Shubham Khanna <khannashubham1197(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Rajendra Kumar Dangwal <dangwalrajendra888(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, euler(at)eulerto(dot)com |
Subject: | Re: Pgoutput not capturing the generated columns |
Date: | 2024-10-23 06:55:55 |
Message-ID: | CAHut+PsNcV6oR0WYmADWj6ROyN_Bcz-nNVz7rWZzK5bV6FiZZg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Oct 23, 2024 at 5:21 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> Additional comment on the 0003 patch
> +# =============================================================================
> +# Misc test.
> +#
> +# A "normal -> generated" replication.
> +#
> +# In this test case we use DROP EXPRESSION to change the subscriber generated
> +# column into a normal column, then verify replication works ok.
> +# =============================================================================
>
> In patch 0003, why do we have the above test? This doesn't seem to be
> directly related to this patch.
>
> --
Perhaps the test should be turned around, to test this feature more directly...
e.g. Replication of table tab(a int, b int) ==> tab(a int, b int, c int)
test_pub=# create table tab(a int, b int);
then, dynamically add a generated column "c" to the publisher table
test_pub=# alter table tab add column c int GENERATED ALWAYS AS (a + b) STORED;
test_pub=# insert into tab values (1,2);
then, verify that replication works for the newly added generated
column "c" to the existing normal column "c" at the subscriber.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Smith | 2024-10-23 07:25:14 | Re: Refactor to use common function 'get_publications_str'. |
Previous Message | Fujii Masao | 2024-10-23 06:47:28 | Re: Fix for consume_xids advancing XIDs incorrectly |