Re: Column Filtering in Logical Replication

On Thu, Sep 2, 2021 at 7:21 AM Rahila Syed <rahilasyed90(at)gmail(dot)com> wrote:
>
...
>
> Also added some more tests. Please find attached a rebased and updated patch.

I fetched and applied the v4 patch.

It applied cleanly, and the build and make check was OK.

But I encountered some errors running the TAP subscription tests, as follows:

...
t/018_stream_subxact_abort.pl ...... ok
t/019_stream_subxact_ddl_abort.pl .. ok
t/020_messages.pl .................. ok
t/021_column_filter.pl ............. 1/9
# Failed test 'insert on column c is not replicated'
# at t/021_column_filter.pl line 126.
# got: ''
# expected: '1|abc'

# Failed test 'update on column c is not replicated'
# at t/021_column_filter.pl line 130.
# got: ''
# expected: '1|abc'
# Looks like you failed 2 tests of 9.
t/021_column_filter.pl ............. Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/9 subtests
t/021_twophase.pl .................. ok
t/022_twophase_cascade.pl .......... ok
t/023_twophase_stream.pl ........... ok
t/024_add_drop_pub.pl .............. ok
t/100_bugs.pl ...................... ok

Test Summary Report
-------------------
t/021_column_filter.pl (Wstat: 512 Tests: 9 Failed: 2)
Failed tests: 6-7
Non-zero exit status: 2
Files=26, Tests=263, 192 wallclock secs ( 0.57 usr 0.09 sys + 110.17
cusr 25.45 csys = 136.28 CPU)
Result: FAIL
make: *** [check] Error 1

------
Kind Regards,
Peter Smith.
Fujitsu Australia