Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Shubham Khanna <khannashubham1197(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.
Date: 2025-04-09 05:11:51
Message-ID: CAHut+Ps2bmFPzfPdE3xAPdD_N8xAyyMe_ER9eGUULHv0PE=J0Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 26, 2025 at 3:54 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Mar 25, 2025 at 5:30 PM Ashutosh Bapat
> <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
> >
> > On Thu, Mar 20, 2025 at 5:54 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > >
> > > * <refsynopsisdiv>
> > > + <cmdsynopsis>
> > > + <command>pg_createsubscriber</command>
> > > + <arg rep="repeat"><replaceable>option</replaceable></arg>
> > > + <group choice="plain">
> > > + <group choice="req">
> > > + <arg choice="plain"><option>-a</option></arg>
> > > + <arg choice="plain"><option>--all</option></arg>
> > > + </group>
> > > + <group choice="req">
> > > + <arg choice="plain"><option>-D</option> </arg>
> > > + <arg choice="plain"><option>--pgdata</option></arg>
> > > + </group>
> > > + <replaceable>datadir</replaceable>
> > > + <group choice="req">
> > > + <arg choice="plain"><option>-P</option></arg>
> > > + <arg choice="plain"><option>--publisher-server</option></arg>
> > > + </group>
> > > + <replaceable>connstr</replaceable>
> > >
> > > Most of this is unrelated to this patch. I suggest making a top-up
> > > patch, we can commit it separately.
> >
> > Isn't this documenting -a/--all option in synopsis. Why do you think
> > it's unrelated?
> >
>
> I was not clear at that stage whether to include it along with the
> core patch, but today, I looked at it while responding to Euler and
> found that it is not required. We can still discuss whether to include
> it, but the main patch can be committed even without this.
>

I've created a separate thread [1] to continue the discussion about
the synopsis.

======
[1] https://www.postgresql.org/message-id/CAHut%2BPueY_DyuBy6SuvJev2DWJVGtg%3D9WG9WXvYQDJu39gV6TQ%40mail.gmail.com

Kind Regards,
Peter Smith.
Fujitsu Australia

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhijie Hou (Fujitsu) 2025-04-09 05:14:42 RE: Fix slot synchronization with two_phase decoding enabled
Previous Message Amit Langote 2025-04-09 05:08:53 Re: [PoC] Reducing planning time when tables have many partitions