| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add common function ReplicationOriginName. |
| Date: | 2022-09-21 09:38:58 |
| Message-ID: | CAHut+Ps2ZEB56E+_yWPRuHo_zkyySSFMV0-_Epvnzu81NDyrhw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 21, 2022 at 3:23 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
...
> Can't we use the existing function ReplicationOriginNameForTablesync()
> by passing relid as InvalidOid for this purpose? We need a check
> inside to decide which name to construct, otherwise, it should be
> fine. If we agree with this, then we can change the name of the
> function to something like ReplicationOriginNameForLogicalRep or
> ReplicationOriginNameForLogicalRepWorkers.
>
This suggestion attaches special meaning to the reild param.
Won't it seem a bit strange for the non-tablesync callers (who
probably have a perfectly valid 'relid') to have to pass an InvalidOid
relid just so they can format the correct origin name?
------
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yuya Watari | 2022-09-21 09:43:51 | Re: [PoC] Reducing planning time when tables have many partitions |
| Previous Message | Thomas Munro | 2022-09-21 09:32:25 | Re: SLRUs in the main buffer pool, redux |