| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description |
| Date: | 2024-09-04 04:59:20 |
| Message-ID: | CAHut+Ps1U53jhw7dSiqDOb-=eKczLmW8iKr1-J=JZFXh4PHbpg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 3, 2024 at 4:12 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
...
> Shall we make the change in code-comment as well:
>
> typedef struct ReplicationSlot
> {
> ...
> /* The time since the slot has become inactive */
> TimestampTz inactive_since;
> }
>
Hi Shveta,
Yes, I think so. I hadn't bothered to include this in the v1 patch
only because the docs are user-facing, but this code comment isn't.
However, now that you've mentioned it, I made the same change here
also. Thanks. See patch v2.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-fix-description-for-inactive_since.patch | application/octet-stream | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2024-09-04 05:04:23 | Re: tiny step toward threading: reduce dependence on setlocale() |
| Previous Message | Amit Kapila | 2024-09-04 04:56:40 | Re: Collect statistics about conflicts in logical replication |