| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add publisher and subscriber to glossary documentation. |
| Date: | 2024-02-26 00:11:02 |
| Message-ID: | CAHut+Ps0_4zU1DVtMoESFk113ASORhmi6s-u+K1LW9bv0e0VhQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Here are some comments for patch v3:
1.
+ <glossentry id="glossary-publication-node">
+ <glossterm>Publication node</glossterm>
+ <glossdef>
+ <para>
+ A <glossterm linkend="glossary-instance">node</glossterm> where a
+ <glossterm
linkend="glossary-publication">publication</glossterm> is defined
+ for <glossterm linkend="glossary-replication">logical
replication</glossterm>.
+ </para>
+ </glossdef>
+ </glossentry>
+
I felt the word "node" here should link to the glossary term "Node",
instead of directly to the term "Instance".
~~
2.
+ <glossentry id="glossary-subscription-node">
+ <glossterm>Subscription node</glossterm>
+ <glossdef>
+ <para>
+ A <glossterm linkend="glossary-instance">node</glossterm> where a
+ <glossterm
linkend="glossary-subscription">subscription</glossterm> is defined
+ for <glossterm linkend="glossary-replication">logical
replication</glossterm>.
+ </para>
+ </glossdef>
+ </glossentry>
+
(same comment as above)
I felt the word "node" here should link to the glossary term "Node",
instead of directly to the term "Instance".
~~
Apart from those links, it looks good to me. Let's see what others think.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-02-26 00:36:57 | Re: Preserve subscription OIDs during pg_upgrade |
| Previous Message | Michael Paquier | 2024-02-25 23:37:20 | Re: ExecAppendAsyncEventWait() in REL_14_STABLE can corrupt PG_exception_stack |