Re: row filtering for logical replication

On Mon, Nov 15, 2021 at 5:09 PM tanghy(dot)fnst(at)fujitsu(dot)com
<tanghy(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Friday, November 12, 2021 6:20 PM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
> >
> > Attaching version 39-
> >
>
> Thanks for the new patch.
>
> I met a problem when using "ALTER PUBLICATION ... SET TABLE ... WHERE ...", the
> publisher was crashed after executing this statement.
>
> Here is some information about this problem.
>
> Steps to reproduce:
> -- publisher
> create table t(a int primary key, b int);
> create publication pub for table t where (a>5);
>
> -- subscriber
> create table t(a int primary key, b int);
> create subscription sub connection 'dbname=postgres port=5432' publication pub;
>
> -- publisher
> insert into t values (1, 2);
> alter publication pub set table t where (a>7);
>
>
> Publisher log:
> 2021-11-15 13:36:54.997 CST [3319891] LOG: logical decoding found consistent point at 0/15208B8
> 2021-11-15 13:36:54.997 CST [3319891] DETAIL: There are no running transactions.
> 2021-11-15 13:36:54.997 CST [3319891] STATEMENT: START_REPLICATION SLOT "sub" LOGICAL 0/0 (proto_version '3', publication_names '"pub"')
> double free or corruption (out)
> 2021-11-15 13:36:55.072 CST [3319746] LOG: received fast shutdown request
> 2021-11-15 13:36:55.073 CST [3319746] LOG: aborting any active transactions
> 2021-11-15 13:36:55.105 CST [3319746] LOG: background worker "logical replication launcher" (PID 3319874) exited with exit code 1
> 2021-11-15 13:36:55.105 CST [3319869] LOG: shutting down
> 2021-11-15 13:36:55.554 CST [3319746] LOG: server process (PID 3319891) was terminated by signal 6: Aborted
> 2021-11-15 13:36:55.554 CST [3319746] DETAIL: Failed process was running: START_REPLICATION SLOT "sub" LOGICAL 0/0 (proto_version '3', publication_names '"pub"')
> 2021-11-15 13:36:55.554 CST [3319746] LOG: terminating any other active server processes
>
>
> Backtrace is attached. I think maybe the problem is related to the below change in 0003 patch:
>
> + free(entry->exprstate);
>

Fixed in V40 [1] using a fix provided by Greg Nancarrow.

-----
[1] https://www.postgresql.org/message-id/CAHut%2BPv-D4rQseRO_OzfEz2dQsTKEnKjBCET9Z-iJppyT1XNMQ%40mail.gmail.com

Kind Regards,
Peter Smith.
Fujitsu Australia