| From: | Vladimir Kokovic <vladimir(dot)kokovic(at)gmail(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_scanner - patch no.1 |
| Date: | 2012-11-14 18:07:00 |
| Message-ID: | CAHsHPqeBoXbxVF1z_0k3Fwa-D879JLnSVUavp5J7L6NHQSHt6w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi,
On 11/13/12, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Hmm, that's definitely wrong - any parts of the pgadmin3 build target
> should be in $SRC/pgadmin. Having it in xtra/ is acceptable if it's
> being built as a library that then gets linked into other projects,
> but if we're adding to pgadmin3_LDADD, then the code should definitely
> not be in xtra/ but in pgadmin/. I'd prefer it not be a library
> personally, so can you move it please?
>
Moved from xtra/pg_scanners to pgadmin/pg_scanners.
>
> 92 is fine - my point is that we support 3 different types of
> PostgreSQL server, that each may have a 9.2 version with different
> syntax, so if we're including the version number to allow multiple
> scanners in the future, then we should also include something to
> differentiate the forks - eg. pg92 for PostgreSQL, as92 for Postgres
> Plus Advanced Server and gp92 for Greenplum Database.
>
For now, pgadmin/pg_scanners contains only pg92 scanner !
Best regards
Vladimir Kokovic
Belgrade, Serbia, 14.November 2012
| Attachment | Content-Type | Size |
|---|---|---|
| changes1.txt | text/plain | 2.9 KB |
| pgadmin3-1.diff | application/octet-stream | 1.3 MB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2012-11-15 14:24:45 | pgAdmin III commit: Avoid querying the catalogs for toast table setting |
| Previous Message | Dave Page | 2012-11-13 12:35:05 | Re: pg_scanner - patch no.1 |