From: | George Gelashvili <ggelashvili(at)pivotal(dot)io> |
---|---|
To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [Patch] Refactor sql template version picking |
Date: | 2017-01-26 20:48:01 |
Message-ID: | CAHowoHbgRM-fwxBqwUCcKUr=UKih5hhec=GP2OPf3byzQS-_ng@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
As a followup, we created this additional patch removing now-redundant sql
templates. If you're interested in how we decided what files to delete, the
script we used is here
<https://gist.github.com/pivotalgeorge/b1ecd3ada209e46742c50218b8c604dc>.
We only removed files that were exactly identical between multiple postgres
versions for the same feature.
This patch should be applied on a master patched with
version-aware-sql-template-loader-refactor.diff
On Thu, Jan 26, 2017 at 12:22 PM, George Gelashvili <ggelashvili(at)pivotal(dot)io>
wrote:
> Hi Hackers!
>
> Since we are preparing to add greenplum support, we made a new template
> loader to automatically pick the available sql template file that
> corresponds to the postgres version number.
>
> Our next patch will be to remove duplicated sql template files since many
> of the files are identical between versions.
>
> Cheers,
> George & Tira
>
Attachment | Content-Type | Size |
---|---|---|
remove-redundant-sql-templates.diff | text/plain | 251.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | George Gelashvili | 2017-01-26 22:40:26 | Re: Acceptance Tests against a browser (WIP) |
Previous Message | Jan Alexander Steffens | 2017-01-26 19:22:49 | Re: [pgAdmin4] [PATCH] Simplify Server's python setup |