Re: [pgadmin-hackers][patch] History Detail Pane

From: George Gelashvili <ggelashvili(at)pivotal(dot)io>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Sarah McAlear <smcalear(at)pivotal(dot)io>, Robert Eckhardt <reckhardt(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Shruti B Iyer <siyer(at)pivotal(dot)io>
Subject: Re: [pgadmin-hackers][patch] History Detail Pane
Date: 2017-06-21 15:45:17
Message-ID: CAHowoHbKfE7_iWmHBdaxVD8d4J8smqMvRKkiNF5s-kcA4+XjjA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

We rebased this on top of latest master.

Cheers,
Matt and George

On Thu, Jun 15, 2017 at 10:43 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> We use Qt 5.8 at the moment, with the updated QtWebKit TP5 release
> from https://github.com/annulen/webkit/releases. The issue occurs on
> Windows and Mac, and probably Linux as well.
>
> Test builds can be found here: https://developer.pgadmin.org/~dpage/debug/
>
> On Thu, Jun 15, 2017 at 2:33 PM, Sarah McAlear <smcalear(at)pivotal(dot)io>
> wrote:
> > Hi Dave!
> >
> > Just to verify, which version of QT are you using? The Readme calls for
> 5.5
> > at the newest. Could you send us the compiled version of the app? Are you
> > only seeing this on Windows?
> >
> > Thanks,
> > Sarah & Shruti & João
> >
> > On Wed, Jun 14, 2017 at 3:46 PM, Sarah McAlear <smcalear(at)pivotal(dot)io>
> wrote:
> >>
> >> Sounds good! We're looking into it.
> >>
> >> On Wed, Jun 14, 2017 at 12:15 PM, Robert Eckhardt <reckhardt(at)pivotal(dot)io
> >
> >> wrote:
> >>>
> >>> Absolutely makes sense.
> >>>
> >>> Matt, Sarah,
> >>>
> >>> Do we understand the issues Dave is mentioning well enough to look into
> >>> it and tackle it?
> >>>
> >>> -- Rob
> >>>
> >>> On Wed, Jun 14, 2017 at 8:12 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> >>>>
> >>>> Hi,
> >>>>
> >>>> Before I commit anything else for this patch, we need to fix the
> >>>> existing changes so they work in the desktop runtime (see the previous
> >>>> thread with the patches for the history pane changes). Have any of
> >>>> your team been able to look at that yet?
> >>>>
> >>>> On Wed, Jun 14, 2017 at 4:07 PM, Sarah McAlear <smcalear(at)pivotal(dot)io>
> >>>> wrote:
> >>>> > Hi Hackers!
> >>>> >
> >>>> > This patch includes a new pane in the history tab that displays the
> >>>> > full
> >>>> > formatted query and meta data about the query.
> >>>> >
> >>>> > Thanks!
> >>>> > Shruti & Sarah
> >>>> >
> >>>> >
> >>>> >
> >>>> >
> >>>> >
> >>>> >
> >>>> > --
> >>>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)
> org)
> >>>> > To make changes to your subscription:
> >>>> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >>>> >
> >>>>
> >>>>
> >>>>
> >>>> --
> >>>> Dave Page
> >>>> Blog: http://pgsnake.blogspot.com
> >>>> Twitter: @pgsnake
> >>>>
> >>>> EnterpriseDB UK: http://www.enterprisedb.com
> >>>> The Enterprise PostgreSQL Company
> >>>>
> >>>>
> >>>> --
> >>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org
> )
> >>>> To make changes to your subscription:
> >>>> http://www.postgresql.org/mailpref/pgadmin-hackers
> >>>
> >>>
> >>
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

Attachment Content-Type Size
create-history-detail-pane.diff text/plain 872.1 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-06-21 15:59:47 pgAdmin 4 commit: Handle missing/dropped synonyms gracefully. Fixes #25
Previous Message Dave Page 2017-06-21 14:38:36 Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React