Re: bug when apply fast default mechanism for adding new column over domain with default value

From: Tender Wang <tndrwang(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alexander Lakhin <exclusion(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: bug when apply fast default mechanism for adding new column over domain with default value
Date: 2025-04-02 15:24:32
Message-ID: CAHewXNnUiWJFe-Bx1obwH2NrvKF6E8CsYp1xL+uRyZE+ec6c7A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> 于2025年4月2日周三 23:15写道：

> Tender Wang <tndrwang(at)gmail(dot)com> writes:
> > So let's add CommandCounterIncrement() after calling
> StoreAttrMissingVal().
>
> Pushed with minor editorialization. I thought for a bit about whether
> the CCI call should be inside StoreAttrMissingVal; but its cohorts in
> heap.c don't do their own CCI calls, so this way seems the least
> surprising.
>

Yes, there is no direct call CCI in heap.c. I also noticed this.
Thanks for pushing.

--
Thanks, Tender Wang

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bertrand Drouvot 2025-04-02 15:27:07 Re: Draft for basic NUMA observability
Previous Message Andres Freund 2025-04-02 15:20:58 BTScanOpaqueData size slows down tests