| From: | Tender Wang <tndrwang(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, tharakan(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: BUG #18866: Running pg_freespace() on views triggers an Abort |
| Date: | 2025-03-28 01:59:05 |
| Message-ID: | CAHewXNn9G3aj735=JUP+gf_AJioppaa-9PrLiGRsHCre9GggmA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> 于2025年3月28日周五 00:01写道：
> Richard Guo <guofenglinux(at)gmail(dot)com> writes:
> > Not related to this issue but I wonder why blkno is verified after
> > the relation is opened. It can be verified beforehand, no?
>
> It makes sense to me to check the parameters left-to-right, so
> I think verifying blkno after relation is fine. It's not like
> there's value in optimizing the failure case.
>
> This does, however, suggest that we ought to check the relkind
> immediately after opening the rel, before the blkno check.
> I'll adjust the patch that way and push.
>
Thanks for pushing.
--
Thanks,
Tender Wang
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2025-03-28 05:00:01 | BUG #18871: Cross-partition MERGE fails with unclear internal error |
| Previous Message | Michael Paquier | 2025-03-28 01:24:21 | Re: BUG #18856: Include directives for postgresql.conf, pg_hba.conf, pg_ident.conf behave inconsistently. |