Re: Eager aggregation, take 3

Tender Wang <tndrwang(at)gmail(dot)com> 于2024年9月4日周三 11:48写道：

>
>
> Richard Guo <guofenglinux(at)gmail(dot)com> 于2024年8月21日周三 15:11写道：
>
>> On Fri, Aug 16, 2024 at 4:14 PM Richard Guo <guofenglinux(at)gmail(dot)com>
>> wrote:
>> > I had a self-review of this patchset and made some refactoring,
>> > especially to the function that creates the RelAggInfo structure for a
>> > given relation. While there were no major changes, the code should
>> > now be simpler.
>>
>> I found a bug in v10 patchset: when we generate the GROUP BY clauses
>> for the partial aggregation that is pushed down to a non-aggregated
>> relation, we may produce a clause with a tleSortGroupRef that
>> duplicates one already present in the query's groupClause, which would
>> cause problems.
>>
>> Attached is the updated version of the patchset that fixes this bug
>> and includes further code refactoring.
>>
>
> The v11-0002 git am failed on HEAD(6c2b5edecc).
>
> tender(at)iZ2ze6la2dizi7df9q3xheZ:/workspace/postgres$ git am
> v11-0002-Implement-Eager-Aggregation.patch
> Applying: Implement Eager Aggregation
> error: patch failed: src/test/regress/parallel_schedule:119
> error: src/test/regress/parallel_schedule: patch does not apply
> Patch failed at 0001 Implement Eager Aggregation
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
>
>
Since MERGE/SPLIT partition has been reverted, the tests *partition_merge*
and *partition_split* should be removed
from parallel_schedule. After doing the above, the 0002 patch can be
applied.

--
Thanks,
Tender Wang