| From: | Tender Wang <tndrwang(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Consistently use macro HeapTupleIsValid to check the validity of tuples in tablecmds.c |
| Date: | 2025-04-10 08:44:24 |
| Message-ID: | CAHewXN=Qr-DOQO4XQYDP8L58wy9VckeV9_3dFXSj5NxWHOb8dg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> 于2025年4月10日周四 10:53写道：
> On Wed, Apr 09, 2025 at 05:43:24PM +0300, Heikki Linnakangas wrote:
> > Agreed. I use both, depending on which mood I'm in.
>
> Same here, extended to OidIsValid(), HeapTupleIsValid(), XLogRecPtr,
> etc., and I tend to prefer such macros, except if consistency of the
> surroundings matter most. FWIW, I think that living with the current
> state of things to limit backpatch pain is fine. There is no need to
> change the existing code as an attempt to apply more standardization
> even if one or more code grammar patterns mean the same thing.
>
OK, makes sense.
--
Thanks, Tender Wang
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2025-04-10 08:53:12 | Re: bug in stored generated column over domain with constraints. |
| Previous Message | Kirill Reshke | 2025-04-10 08:25:00 | Re: speedup COPY TO for partitioned table. |