| From: | David Christensen <david+pg(at)pgguru(dot)net> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Adding comments to help understand psql hidden queries |
| Date: | 2024-04-04 16:12:18 |
| Message-ID: | CAHM0NXi19okhdByr6cNDwqHtjG7umjbY5OmRMwgropZHs01KGw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 4, 2024 at 9:32 AM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> On 03.04.24 19:16, David Christensen wrote:
> > I removed _() in the output of the query/stars since there'd be no
> > sensible existing translations for the constructed string, which
> > included the query string itself. If we need it for the "QUERY"
> > string, this could be added fairly easily, but the existing piece
> > would have been nonsensical and never used in practice.
>
> "QUERY" is currently translated. Your patch loses that.
I see; enclosed is v5 which fixes this.
The effective diff from the last one is:
- char *label = "QUERY";
+ char *label = _("QUERY");
and
- label = psprintf("QUERY (\\%s)", curcmd);
+ label = psprintf(_("QUERY (\\%s)"), curcmd);
Best,
David
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Improve-SQL-comments-on-echo-hidden-output.patch | application/octet-stream | 21.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2024-04-04 16:13:04 | Re: WIP Incremental JSON Parser |
| Previous Message | Tom Lane | 2024-04-04 16:04:45 | Re: WIP Incremental JSON Parser |