Re: Adding comments to help understand psql hidden queries

From: David Christensen <david+pg(at)pgguru(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Adding comments to help understand psql hidden queries
Date: 2025-01-30 20:55:00
Message-ID: CAHM0NXgs4-k3cSg2J0rJd2CPiT40ZfYGs4SK6MAHi-HB3B7dUA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jan 18, 2025 at 2:37 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> David Christensen <david+pg(at)pgguru(dot)net> writes:
> > Any further concerns/issues with this patch that I can address to help
> > move it forward?
>
> I got around to looking at this finally --- sorry that it's been on
> the back burner for so long. I think this is basically a good idea
> but it still requires a lot of sanding-down of rough edges.

Hi Tom, thanks for the detailed feedback. I'll take your v6 and see
about adding the additional changes; I agree with what you've pointed
out at the high level, and will respond with additional questions of
my own if things seem ambiguous in terms of approach.

Thanks,

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2025-01-30 22:39:28 Re: Conflict detection for update_deleted in logical replication
Previous Message Melanie Plageman 2025-01-30 20:36:12 Re: BitmapHeapScan streaming read user and prelim refactoring