Reassign variable value in XLogReadRecord

From: "Dickson S(dot) Guedes" <listas(at)guedesoft(dot)net>
To: pg-dev <pgsql-hackers(at)postgresql(dot)org>
Subject: Reassign variable value in XLogReadRecord
Date: 2013-04-09 01:31:56
Message-ID: CAHHcrepdu9f5nmn3wYV4UeZY7YdGAApTGX3qzbn-zCFVhVHddA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

While walking in the code I see the following code in
src/backend/access/transam/xlogreader.c:177-191

XLogRecord *
XLogReadRecord(XLogReaderState *state, XLogRecPtr RecPtr, char **errormsg)
{
XLogRecord *record;
XLogRecPtr targetPagePtr;
bool randAccess = false; <=== assign
uint32 len,
total_len;
uint32 targetRecOff;
uint32 pageHeaderSize;
bool gotheader;
int readOff;

randAccess = false; <== reassign
/* reset error state */

Do I am missing something or the last one is unnecessary?

Best regards.
--
Dickson S. Guedes
mail/xmpp: guedes(at)guedesoft(dot)net - skype: guediz
http://github.com/guedes - http://guedesoft.net
http://www.postgresql.org.br

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Brendan Jurd 2013-04-09 02:16:43 Re: [PATCH] Exorcise "zero-dimensional" arrays (Was: Re: Should array_length() Return NULL)
Previous Message Bruce Momjian 2013-04-08 23:35:53 Re: Re: [PATCH] Exorcise "zero-dimensional" arrays (Was: Re: Should array_length() Return NULL)