Re: BUG #7534: walreceiver takes long time to detect n/w breakdown

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Cc: Amit Kapila <amit(dot)kapila(at)huawei(dot)com>, pgsql-bugs(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: BUG #7534: walreceiver takes long time to detect n/w breakdown
Date: 2012-10-13 16:35:12
Message-ID: CAHGQGwHyMwP8YqmcDynrsGbOax=dL7HmxAnZ68Azr36_7wJ0WQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Thu, Oct 11, 2012 at 11:52 PM, Heikki Linnakangas
<hlinnakangas(at)vmware(dot)com> wrote:
> On 11.10.2012 13:17, Amit Kapila wrote:
>>>
>>> How does this look now?
>>
>>
>> The Patch is fine and test results are also fine.
>
>
> Ok, thanks. Committed.

I found one typo. The attached patch fixes that typo.

ISTM you need to update the protocol.sgml because you added
the field 'replyRequested' to WalSndrMessage and StandbyReplyMessage.

Is it worth adding the same mechanism (send back the reply immediately
if walsender request a reply) into pg_basebackup and pg_receivexlog?

Regards,

--
Fujii Masao

Attachment Content-Type Size
typo.patch application/octet-stream 754 bytes

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Thom Brown 2012-10-13 22:56:43 pg_ctl restart issue with relative paths
Previous Message Jan Vodička 2012-10-13 13:28:08 Re: BUG #7590: Data corruption using pg_dump only with -Z parameter

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2012-10-13 17:26:18 Re: proposal - assign result of query to psql variable
Previous Message Jim Nasby 2012-10-13 15:54:46 Optimizer regression