| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Remove unused function from walsender.c |
| Date: | 2016-04-12 19:37:49 |
| Message-ID: | CAHGQGwHuv3TqZu=72CQANW6v-b-1d1cx_tXBG9g3J-oPJWOH5Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 12, 2016 at 6:36 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On 11 April 2016 at 08:05, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
>>
>> There is an unused function GetOldestWALSendPointer() in walsender.c.
>> Per comment, it was introduced because we may need it in the future for
>> synchronous replication.
>>
>> Now we have very similar function SyncRepGetOldestSyncRecPtr() in
>> syncrep.c. Which makes me think that GetOldestWALSendPointer()
>> no longer needs to be maintained. So, is it time to remove that unused
>> function?
>
>
> Seems sensible cleanup to me.
Yep, pushed the cleanup patch.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2016-04-12 19:43:35 | Re: Support for N synchronous standby servers - take 2 |
| Previous Message | Andres Freund | 2016-04-12 19:28:01 | Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold < |