From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Add hooks for session start and session end, take two |
Date: | 2019-10-02 14:52:31 |
Message-ID: | CAHGQGwHtm1wyHjSBDUv7b18XXk=Kj1gB9pjTpak0duPJbAyG7w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Wed, Oct 2, 2019 at 10:08 PM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>
> On 2019-Oct-02, Michael Paquier wrote:
>
> > On Wed, Oct 02, 2019 at 01:27:50PM +0900, Fujii Masao wrote:
> > > If only session end hook is problematic, you will commit session start
> > > hook again?
> >
> > Sure, it would be possible to cut the apple in half here. Now my
> > understanding was that both hooks were a set. What do people think?
>
> I think that having just session start is still useful
+1
Regarding session end hook, you can do the almost same thing as that hook
by calling on_shmem_exit(), before_shmem_exit() or on_proc_exit() in
other hook like session start hook. This approach also has the same issue
discussed upthread, though. Anyway, I'm not sure if session end hook is
"actually" necessary.
Regards,
--
Fujii Masao
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2019-10-02 17:07:40 | Re: pgsql: Add hooks for session start and session end, take two |
Previous Message | Alvaro Herrera | 2019-10-02 13:08:39 | Re: pgsql: Add hooks for session start and session end, take two |