| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Logical replication support for initial data copy |
| Date: | 2017-03-30 18:04:27 |
| Message-ID: | CAHGQGwHtFDdu7ZStgg1UNB0vxzDt49nEjjkn85ODUiM1EyN7CQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Thu, Mar 23, 2017 at 9:59 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> Logical replication support for initial data copy
+ case T_SQLCmd:
+ if (MyDatabaseId == InvalidOid)
+ ereport(ERROR,
+ (errmsg("not connected to database")));
This error message doesn't seem to follow the error message style in docs.
Also It seems a bit unclear to me. So what about replacing it with
something like the following?
ERROR: must connect to database to execute command \"%s\"
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2017-03-30 18:20:47 | pgsql: Default monitoring roles |
| Previous Message | Tom Lane | 2017-03-30 17:12:53 | Re: Use \if ... \elif ... \else ... \endif to simplify alternative in psql scripting. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Verite | 2017-03-30 18:12:14 | Re: PATCH: Batch/pipelining support for libpq |
| Previous Message | Bruce Momjian | 2017-03-30 17:47:45 | Re: Patch: Write Amplification Reduction Method (WARM) |