From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | Peter Geoghegan <pg(at)heroku(dot)com> |
Cc: | Sameer Thakur <samthakur74(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: pg_stat_statements: calls under-estimation propagation |
Date: | 2013-12-06 19:02:55 |
Message-ID: | CAHGQGwHaRrSr1ZEiAJRNH07Afa0A81H9opbF99huJtwmXsYa_Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Nov 24, 2013 at 10:58 AM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> On Mon, Nov 18, 2013 at 1:54 AM, Sameer Thakur <samthakur74(at)gmail(dot)com> wrote:
>> Please find v10 of patch attached. This patch addresses following
>> review comments
>
> I've cleaned this up - revision attached - and marked it "ready for committer".
>
> I decided that queryid should be of type oid, not bigint. This is
> arguably a slight abuse of notation, but since ultimately Oids are
> just abstract object identifiers (so say the docs), but also because
> there is no other convenient, minimal way of representing unsigned
> 32-bit integers in the view that I'm aware of, I'm inclined to think
> that it's appropriate.
There seems to be no problem even if we use bigint as the type of
unsigned 32-bit integer like queryid. For example, txid_current()
returns the transaction ID, i.e., unsigned 32-bit integer, as bigint.
Could you tell me what the problem is when using bigint for queryid?
Regards,
--
Fujii Masao
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Gierth | 2013-12-06 19:32:16 | Re: WITHIN GROUP patch |
Previous Message | Tom Lane | 2013-12-06 18:38:54 | Re: WITHIN GROUP patch |