From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Reporting WAL file containing checkpoint's REDO record in pg_controldata's result |
Date: | 2012-03-23 17:05:59 |
Message-ID: | CAHGQGwH_Htix2PrFb=ULXeFA-uxWEpUaw630s-E_t5tW9=e3Fg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Mar 24, 2012 at 1:49 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Mar 23, 2012 at 12:42 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> On Fri, Mar 23, 2012 at 9:41 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>> On Fri, Mar 23, 2012 at 6:13 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>>> On Fri, Mar 23, 2012 at 5:56 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>>>>> Might it be a good idea to put it on it's own row instead of changing
>>>>> the format of an existing row, in order not to break scripts and
>>>>> programs that are parsing the previous output?
>>>>
>>>> Good idea! What row name should we use for the WAL file containing
>>>> REDO record? "Latest checkpoint's REDO file"?
>>>
>>> Sounds good to me. I like the idea, too. The status quo is an
>>> unnecessary nuisance, so this will be a nice usability improvement.
>>
>> Attached patch adds new row "Latest checkpoint's REDO WAL segment:" into
>> the result of pg_controldata. I used the term "WAL segment" for the row name
>> instead of "file" because "WAL segment" is used in another row "Bytes per WAL
>> segment:". But better name?
>
> s/segment/file/g?
Yep, "file" might be more intuitive for a user than "segment". Attached is the
"file" version of the patch.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
Attachment | Content-Type | Size |
---|---|---|
pg_controldata_walfilename_v3.patch | application/octet-stream | 1.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Farina | 2012-03-23 17:38:31 | Re: Standbys, txid_current_snapshot, wraparound |
Previous Message | Robert Haas | 2012-03-23 17:03:48 | Re: query cache |