Re: pg_resetxlog to clear backup start/end locations.

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_resetxlog to clear backup start/end locations.
Date: 2014-06-30 03:57:57
Message-ID: CAHGQGwHC+=GVS50d2pKqm82axaUmTFJR92+c2oMUYowpLUbNXQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 30, 2014 at 12:49 PM, Kyotaro HORIGUCHI
<horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> Mmm. This patch is found that useless, from the first.
>
>> Thanks for the patch! But when I read the source code of pg_resetxlog,
>> I found that it has already reset the backup locations. Please see
>> RewriteControlFile() which does that. So I wonder if we need nothing
>> at least in HEAD for the purpose which you'd like to achieve. Thought?
>
> Thank you for noticing of that, I checked by myself and found
> that what this patch intended is already done in all
> origin/REL9_x_STABLE. What is more, that code has not changed for
> over hundreds of commits on each branch, that is, maybe from the
> first. I don't know how I caught in such a stupid
> misunderstanding, but all these patches are totally useless.

So we should mark this patch as "Rejected Patches"?

> Sorry for taking your time for such a useless thing and thank you
> for your kindness.

No problem!

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Abhijit Menon-Sen 2014-06-30 03:58:42 Re: 9.5 CF1
Previous Message Kyotaro HORIGUCHI 2014-06-30 03:49:32 Re: pg_resetxlog to clear backup start/end locations.