Re: pgsql: doc: Further clarify how recovery target parameters are applied

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: doc: Further clarify how recovery target parameters are applied
Date: 2019-11-07 17:10:05
Message-ID: CAHGQGwH3uaNRdMuxzbRUfck7e6b_8qvdAZVBQGwgw+AoE=VKSw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Fri, Nov 8, 2019 at 12:23 AM Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>
> On 2019-11-06 10:49, Fujii Masao wrote:
> > On Wed, Nov 6, 2019 at 4:29 PM Peter Eisentraut
> > <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> >>
> >> On 2019-11-06 05:48, Fujii Masao wrote:
> >>> Patch attached. As I argued upthread, IMO it's better to remove
> >>> the latter description from the doc and the patch does that.
> >>> Also the patch adds "mainly" into the former description.
> >>
> >> I think we should list explicitly what is applied and what is not. This
> >> is the reference documentation after all.
> >
> > That's possible, but may make the document more complicated and confusing,
> > I'm afraid. Because the parameters used for archive recovery and standby mode
> > are not categorized cleanly.
>
> After reading this again and again, I think the best fix to get PG12
> into "correct" shape is to just remove the offending sentence:

+1

> As we are discussing in other threads, there is further opportunity to
> reorganize how these settings interact, but that's a different project.

Yes.

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2019-11-07 17:28:27 pgsql: Fix SET CONSTRAINTS .. DEFERRED on partitioned tables
Previous Message Tom Lane 2019-11-07 16:23:20 pgsql: Fix integer-overflow edge case detection in interval_mul and pgb