| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Josh Berkus <josh(at)agliodbs(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Venkata Balaji N <nag1010(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Patch: raise default for max_wal_segments to 1GB |
| Date: | 2015-03-03 10:12:49 |
| Message-ID: | CAHGQGwGvWcmMBcXRQ+dC=7hNNEsOS62miGsLVvNUy0f-jHeznw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 3, 2015 at 8:51 AM, Josh Berkus <josh(at)agliodbs(dot)com> wrote:
> On 03/02/2015 03:43 PM, Andres Freund wrote:
>> Hi,
>>
>> On 2015-03-02 15:40:27 -0800, Josh Berkus wrote:
>>> ! #max_wal_size = 1GB # in logfile segments
>>
>> Independent of the rest of the changes, the "in logfile segments" bit
>> should probably be changed.
>
> Point! Although I think it's fair to point out that that wasn't my
> omission, but Heikki's.
>
> Version C, with that correction, attached.
Minor comments:
"The default settings are 5 minutes and 128 MB, respectively." in wal.sgml
needs to be updated.
int max_wal_size = 8; /* 128 MB */
It's better to update the above code in xlog.c. That's not essential, though.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2015-03-03 10:14:19 | Re: Patch: raise default for max_wal_segments to 1GB |
| Previous Message | Shigeru Hanada | 2015-03-03 10:07:44 | Re: Join push-down support for foreign tables |