Re: Proposal : REINDEX xxx VERBOSE

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Fabrízio Mello <fabriziomello(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Proposal : REINDEX xxx VERBOSE
Date: 2015-05-15 11:28:52
Message-ID: CAHGQGwGsd1avJdY2nEAGcx4urd5jJJpg60Ha3y9y7gJSTzMYPg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 14, 2015 at 4:30 PM, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com> wrote:
> On Thu, May 14, 2015 at 9:58 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Wed, May 13, 2015 at 8:25 PM, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com> wrote:
>>> The v15 patch emits a line for each table when reindexing multiple
>>> tables, and emits a line for each index when reindexing single table.
>>> But v14 patch emits a line for each index, regardless of reindex target.
>>> Should I change back to v14 patch?
>>
>> Uh, maybe. What made you change it?
>>
>
> I thought that the users who want to reindex multiple tables are
> interested in the time to reindex whole table takes.
> But I think it seems sensible to emit a line for each index even when
> reindex multiple tables.
> The v16 patch is based on v14 and a few modified is attached.

Thanks for updating the patch!

The regression test failed because you forgot to remove the trailng period
from the verbose message in the "expected file" of the regression test.
I just fixed it and push the patch.

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2015-05-15 11:36:05 Re: feature freeze and beta schedule
Previous Message Heikki Linnakangas 2015-05-15 11:27:13 pgsql: Allow GiST distance function to return merely a lower-bound.