log message in proto.c

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: log message in proto.c
Date: 2019-09-24 09:41:02
Message-ID: CAHGQGwGm-Vee=_Aa1dK9LNqr89seer+zJSmNtBzsZJ1QoHaN8A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

src/backend/replication/logical/proto.c
action = pq_getmsgbyte(in);
if (action != 'N')
elog(ERROR, "expected new tuple but got %d",
action);

"%d" in the above message should be "%c" because the type of
the variable "action" is char? There are other log messages that
"%c" is used for such variable, in proto.c. Seems the above is
only message that "%d" is used for such variable.

Regards,

--
Fujii Masao

Attachment Content-Type Size
improve-elog-message-in-proto.patch application/octet-stream 662 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-09-24 09:49:17 Re: PostgreSQL12 and older versions of OpenSSL
Previous Message Amit Kapila 2019-09-24 09:30:48 Re: abort-time portal cleanup