From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Improve tab completion for REFRESH MATERIALIZED VIEW |
Date: | 2016-01-26 14:08:01 |
Message-ID: | CAHGQGwGjBQ0jaPVivFEfT-jh3HEU9VvjAX+1REh4Jy+wPDGcsw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jan 26, 2016 at 10:25 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Tue, Jan 26, 2016 at 9:52 PM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>> Tab completion for REFRESH command is oddly with following scenario.
>>
>> =# REFRESH MATERIALIZED VIEW CONCURRENTLY hoge_mv [Tab]
>>
>> It shows only WITH DATA option without WITH NO DATA option.
>> Attached patch improves tab completion for WITH DATA/NO DATA option of
>> REFRESH MATERIALIZED VIEW.
>
> Correct. Nice catch and good patch.
The patch looks good to me.
While testing the patch, I found that
REFRESH MATERIALIZED VIEW <tab> doesn't list the materialized views.
I added the following change to the patch to fix that problem. Patch attached.
- {"MATERIALIZED VIEW", NULL, NULL},
+ {"MATERIALIZED VIEW", NULL, &Query_for_list_of_matviews},
Regards,
--
Fujii Masao
Attachment | Content-Type | Size |
---|---|---|
improve_tab_completion_for_refresh_v2.patch | application/octet-stream | 2.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2016-01-26 14:24:09 | Re: Improve tab completion for REFRESH MATERIALIZED VIEW |
Previous Message | Magnus Hagander | 2016-01-26 14:07:34 | Re: pg_lsn cast to/from int8 |