| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Enforcing that all WAL has been replayed after restoring from backup |
| Date: | 2011-08-17 09:26:17 |
| Message-ID: | CAHGQGwGXJyLP-OY7Xndvs4+U6qNw+n7oKb1XMebpVd0AfetbXg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 17, 2011 at 5:49 PM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> Hmm, this behaves slightly differently, if you first try to start the
> restored server without recovery.conf, stop recovery, and restart it after
> adding recovery.conf. But I guess that's not a big deal, the check is simply
> skipped in that case, which is what always happens without this patch
> anyway.
Oh, I forgot to consider that case. Yeah, I agree with you.
> Committed this to 9.1,
Thanks a lot!
> but kept master as it was.
So, in master, we should change pg_controldata.c and pg_resetxlog.c for
new pg_control field "backupEndRequired"?
> (sorry for the delay, I wanted to fix the bogus comment as soon as I saw it,
> but needed some time to ponder the rest of the patch)
NM. Thanks!
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2011-08-17 09:37:47 | Re: Enforcing that all WAL has been replayed after restoring from backup |
| Previous Message | Magnus Hagander | 2011-08-17 09:02:17 | Re: [COMMITTERS] pgsql: Adjust total size in pg_basebackup progress report when reality |