| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: [HACKERS] Creating backup history files for backups taken from standbys |
| Date: | 2018-03-01 17:29:13 |
| Message-ID: | CAHGQGwGSvUNiAWXEdiH+moLBMyDCi9GZp4xHufucNOsBd6pK-g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 2, 2018 at 2:06 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Fri, Feb 02, 2018 at 12:47:26AM +0900, Fujii Masao wrote:
>> The patch basically looks good to me. Here are some small comments.
>>
>> <para>
>> The backup history file is not created in the database cluster backed up.
>> </para>
>>
>> The above should be deleted in pg_basebackup.sgml.
>>
>> * During recovery, since we don't use the end-of-backup WAL
>> * record and don't write the backup history file, the
>>
>> This comment needs to be updated in xlog.c.
>
> Thanks Fujii-san for the review. Indeed those portions need a refresh..
Thanks for updating the patch!
+ * write a backup history file with the same name.
So more than one backup history files with the same name
but the diffferent content can be created and archived.
Isn't this problematic because the backup history file that
users want to use later might be overwritten unexpectedly?
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-03-01 17:44:20 | Re: New gist vacuum. |
| Previous Message | Tom Lane | 2018-03-01 17:23:30 | Re: 2018-03 Commitfest starts tomorrow |