| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | minor issues in pg_rewind |
| Date: | 2015-06-10 17:38:54 |
| Message-ID: | CAHGQGwGEw8R25mN1+mNDuFNLwLJQxjLx=1zKxL7ECHhSbLOSDg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Attached patch fixes the minor issues in pg_rewind. The fixes are
* Remove invalid option character "N" from the third argument (valid option
string) of getopt_long().
* Use pg_free() or pfree() to free the memory allocated by pg_malloc() or
palloc() instead of always using free().
* Assume problem is no disk space if write() fails but doesn't set errno.
* Fix several typos.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| fix_minor_issues_in_pg_rewind_v1.patch | text/x-diff | 5.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-06-10 17:39:10 | Re: s_lock() seems too aggressive for machines with many sockets |
| Previous Message | Joshua D. Drake | 2015-06-10 17:24:02 | Re: skipping pg_log in basebackup (was Re: pg_basebackup and pg_stat_tmp directory) |