From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | "Syed, Rahila" <Rahila(dot)Syed(at)nttdata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [REVIEW] Re: Compression of full-page-writes |
Date: | 2015-03-11 03:19:35 |
Message-ID: | CAHGQGwG=TGqZU0TKeb_7iwEk1BrSru_gGzXUBX+HDTVd34hHaw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Mar 9, 2015 at 9:08 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Mon, Mar 9, 2015 at 4:29 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> On Thu, Mar 5, 2015 at 10:08 PM, Michael Paquier
>> <michael(dot)paquier(at)gmail(dot)com> wrote:
>>> On Thu, Mar 5, 2015 at 9:14 PM, Syed, Rahila <Rahila(dot)Syed(at)nttdata(dot)com> wrote:
>>>> Please find attached a patch. As discussed, flag to denote compression and presence of hole in block image has been added in XLogRecordImageHeader rather than block header.
>>
>> Thanks for updating the patch! Attached is the refactored version of the patch.
>
> Cool. Thanks!
>
> I have some minor comments:
Thanks for the comments!
> + Turning this parameter on can reduce the WAL volume without
> "Turning <value>on</> this parameter
That tag is not used in other place in config.sgml, so I'm not sure if
that's really necessary.
Regards,
--
Fujii Masao
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2015-03-11 04:01:58 | Re: pg_rewind in contrib |
Previous Message | Michael Paquier | 2015-03-11 03:07:33 | Re: moving from contrib to bin |