Re: pgsql: Add support for managing physical replication slots to pg_receiv

On Mon, Oct 6, 2014 at 7:57 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Add support for managing physical replication slots to pg_receivexlog.
>
> pg_receivexlog already has the capability to use a replication slot to
> reserve WAL on the upstream node. But the used slot currently has to
> be created via SQL.
>
> To allow using slots directly, without involving SQL, add
> --create-slot and --drop-slot actions, analogous to the logical slot
> manipulation support in pg_recvlogical.
>
> Author: Michael Paquier
> Discussion: CABUevEx+zrOHZOQg+dPapNPFRJdsk59b=TSVf30Z71GnFXhQaw(at)mail(dot)gmail(dot)com
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/pg/commitdiff/d9f38c7a555dd5a6b81100c6d1e4aa68342d8771
>
> Modified Files
> --------------
> doc/src/sgml/ref/pg_receivexlog.sgml | 31 ++++++-
> src/bin/pg_basebackup/pg_receivexlog.c | 155 ++++++++++++++++++++++++++++----
> 2 files changed, 170 insertions(+), 16 deletions(-)
>
>
> --
> Sent via pgsql-committers mailing list (pgsql-committers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-committers

This patch changed pg_receivexlog so that it creates new connection
before creating the slot, etc, but ISTM that it forgets to close the connection.
Probably something like attached patch needs to be applied.

Regards,

--
Fujii Masao