Re: Regarding WAL Format Changes

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Amit Kapila <amit(dot)kapila(at)huawei(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Regarding WAL Format Changes
Date: 2012-06-27 17:26:38
Message-ID: CAHGQGwFh3jRh-7q=oDnvcE8oo=6D-YE4F51-imVL5GcRx9aw_g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 28, 2012 at 1:13 AM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> On 27.06.2012 18:55, Fujii Masao wrote:
>>
>> On Wed, Jun 27, 2012 at 11:56 PM, Heikki Linnakangas
>> <heikki(dot)linnakangas(at)enterprisedb(dot)com>  wrote:
>>>
>>> On 27.06.2012 17:14, Amit Kapila wrote:
>>>>
>>>>
>>>> 1. Function header for following functions still contains referece to
>>>> log,
>>>> seg
>>>>    a. InstallXLogFileSegment()
>>>>    b. RemoveOldXlogFiles()
>>>>    c. XLogFileCopy()
>>>>    d. XLogGetLastRemoved()
>>>>    e. UpdateLastRemovedPtr()
>>>>    f. RemoveOldXlogFiles()
>>>
>>>
>>>
>>> Thanks, fixed.
>>
>>
>> There is still reference to log/seg in the comment of
>> InstallXLogFileSegment().
>> The attached patch should be applied?
>
>
> Thanks, applied. Sorry for being so sloppy with this..

No problem. WAL format change you did is really nice!

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2012-06-27 17:58:41 Re: [ADMIN] pg_basebackup blocking all queries with horrible performance
Previous Message Fujii Masao 2012-06-27 17:24:05 Re: [ADMIN] pg_basebackup blocking all queries with horrible performance