From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | pgsql-docs <pgsql-docs(at)postgresql(dot)org> |
Subject: | Re: Mark a reloption as indexterm |
Date: | 2019-04-15 16:13:35 |
Message-ID: | CAHGQGwFORd2y4fnmQd4ZR0Yx6tt4rsDph45zjb3A1dn_9S8Ffw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-docs |
On Tue, Apr 16, 2019 at 12:35 AM Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
>
> On 2019-Apr-16, Fujii Masao wrote:
>
> > On Sat, Apr 13, 2019 at 1:30 AM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> > >
> > > On 2019-Apr-12, Fujii Masao wrote:
> > >
> > >
> > > > OTOH, originally I thought that the following style is smarter.
> > > >
> > > > xxx
> > > > configuration parameter, XXX
> > > > storage parameter, Storage Parameter
> > >
> > > Ah. Well, I like this style. Let's do that.
> >
> > So I used <secondary> tag again for the above style if both reloption
> > and guc with the same parameter name exist. Attached is the updated
> > version of the patch. This patch also marks index-reloption as indexterm.
>
> I checked the HTML output.
Thanks for the review!
> For autovacuum it says "configuration
> parameters" rather than "configuration parameter". Other than that, it
> looks good to me. (I didn't check that all storage options were covered.)
Good catch! Seems "configuration parameters" had been used for autovacuum
parameter since old version. I agree to replace it with "configuration
parameter"
for the sake of consistency. But I think that it's better to do that by
the separate patch because they are separate things.
Regards,
--
Fujii Masao
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2019-04-15 16:15:31 | Re: Mark a reloption as indexterm |
Previous Message | Alvaro Herrera | 2019-04-15 15:35:36 | Re: Mark a reloption as indexterm |