From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Euler Taveira <euler(at)timbira(dot)com(dot)br>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_resetxlog sentences |
Date: | 2015-09-17 03:25:36 |
Message-ID: | CAHGQGwFAoh1rqj0BDBXLXj5pSQscOQTJoyL30HoF45Rd-vaYEg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Sep 17, 2015 at 5:00 AM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Robert Haas wrote:
>> On Tue, Sep 15, 2015 at 9:52 PM, Euler Taveira <euler(at)timbira(dot)com(dot)br> wrote:
>> > While updating translations, I came across those almost similar sentences.
>> >
>> > pg_controldata.c
>> >
>> > 273 printf(_("Latest checkpoint's oldestCommitTs: %u\n"),
>> > 274 ControlFile.checkPointCopy.oldestCommitTs);
>> >
>> > pg_resetxlog.c
>> >
>> > 668 printf(_("Latest checkpoint's oldest CommitTs: %u\n"),
>> > 669 ControlFile.checkPointCopy.oldestCommitTs);
>> > 670 printf(_("Latest checkpoint's newest CommitTs: %u\n"),
>> > 671 ControlFile.checkPointCopy.newestCommitTs);
>> >
>> > To be consistent, let's change pg_resetxlog to mimic pg_controldata
>> > sentence. Patch is attached. It is new in 9.5 so backpatch is needed.
>>
>> Seems like a good idea to me. Anyone disagree?
>
> OK with me.
+1
One relevant question is; why doesn't pg_controldata report newestCommitTs?
Regards,
--
Fujii Masao
From | Date | Subject | |
---|---|---|---|
Next Message | David E. Wheeler | 2015-09-17 04:00:55 | tsvector work with citext |
Previous Message | Petr Jelinek | 2015-09-17 03:25:27 | Re: a funnel by any other name |